refactor(object_merger)!: fix namespace and directory structure #7642

technolojin · 2024-06-24T05:38:45Z

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

Align directory structure to follow the coding guidelines.
Clean unused dependencies list

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2024-06-24T05:52:46Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d849e9) to head (e7baa9e).
Report is 534 commits behind head on main.

Files	Patch %	Lines
...ject_merger/src/object_association_merger_node.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #7642       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967      62     -1905     
  Lines      135941    3345   -132596     
  Branches    42122     247    -41875     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700    3345    -89355     
+ Partials    22721       0    -22721

Flag	Coverage Δ
differential	`0.00% <0.00%> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-25T08:27:42Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

esteve

@technolojin thanks for submitting this PR. Header files must be in autoware_object_merger, not autoware/object_merger. Also, if they are not needed by downstream packages, they should be moved to src to keep them private.

technolojin · 2024-06-25T08:56:05Z

@technolojin thanks for submitting this PR. Header files must be in autoware_object_merger, not autoware/object_merger. Also, if they are not needed by downstream packages, they should be moved to src to keep them private.

@esteve Thank you. Those were my open points during this work. I will implement in that way.

technolojin · 2024-06-25T09:22:17Z

@esteve resolved in 0c0139f

yukkysaito

LGTM

esteve

@technolojin could you fix the DCO issues? All the commits must be signed by you. Also, it'd be nice to move the header files to the src folder, like this:

https://github.com/autowarefoundation/autoware.universe/tree/main/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src

technolojin · 2024-06-26T02:35:29Z

@esteve

DCO Issue is resolved.
header file for the node is moved into src 35f84fd

Signed-off-by: Taekjin LEE <[email protected]>

technolojin · 2024-07-01T05:01:24Z

@esteve
I am waiting your response.

esteve

@technolojin I meant moving all the headers, it doesn't seem that there are any downstream packages that depend on these headers, so it's safe to keep them private. But it's optional, so up to you if you want to move them. Thanks for addressing my feedback.

…warefoundation#7642) * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename node.hpp to object_association_merger_node.hpp Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency in package.xml Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: add ssp.hpp to object association solver includes Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association node Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>

…warefoundation#7642) * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename node.hpp to object_association_merger_node.hpp Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency in package.xml Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: add ssp.hpp to object association solver includes Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association node Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: palas21 <[email protected]>

…warefoundation#7642) * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename node.hpp to object_association_merger_node.hpp Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency in package.xml Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: add ssp.hpp to object association solver includes Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association node Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename node.hpp to object_association_merger_node.hpp Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency in package.xml Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association modules Signed-off-by: Taekjin LEE <[email protected]> * refactor: add ssp.hpp to object association solver includes Signed-off-by: Taekjin LEE <[email protected]> * refactor: update include paths for object association node Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 24, 2024

technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024

technolojin force-pushed the refactor/namespace_object_merger branch from ef7f48e to ec75674 Compare June 24, 2024 07:55

technolojin changed the title ~~refactor(object_merger): namespace fix~~ refactor(object_merger!: fix namespace and directory structure Jun 25, 2024

technolojin changed the title ~~refactor(object_merger!: fix namespace and directory structure~~ refactor(object_merger)!: fix namespace and directory structure Jun 25, 2024

technolojin marked this pull request as ready for review June 25, 2024 08:48

technolojin requested review from YoshiRi and yukkysaito as code owners June 25, 2024 08:48

esteve requested changes Jun 25, 2024

View reviewed changes

technolojin requested a review from esteve June 25, 2024 09:22

esteve mentioned this pull request Jun 25, 2024

Prefix packages with autoware_ prefix and keep code in autoware namespace autowarefoundation/autoware#4569

Open

yukkysaito approved these changes Jun 25, 2024

View reviewed changes

esteve requested changes Jun 25, 2024

View reviewed changes

technolojin force-pushed the refactor/namespace_object_merger branch from 27d7827 to aa14e21 Compare June 25, 2024 23:59

technolojin self-assigned this Jun 26, 2024

technolojin requested a review from esteve June 26, 2024 02:35

technolojin force-pushed the refactor/namespace_object_merger branch from 35f84fd to 1f6c0b7 Compare June 28, 2024 01:20

technolojin added 8 commits June 28, 2024 10:23

refactor: update include paths for object association modules

1f9ebbc

Signed-off-by: Taekjin LEE <[email protected]>

refactor: update include paths for object association modules

6ba7ad0

Signed-off-by: Taekjin LEE <[email protected]>

refactor: rename node.hpp to object_association_merger_node.hpp

77c22f1

Signed-off-by: Taekjin LEE <[email protected]>

refactor: update include paths for object association modules

438db02

Signed-off-by: Taekjin LEE <[email protected]>

refactor: update include paths for object association modules

7da3d82

Signed-off-by: Taekjin LEE <[email protected]>

refactor: remove unused dependency in package.xml

fa72dcd

Signed-off-by: Taekjin LEE <[email protected]>

refactor: update include paths for object association modules

a46b098

Signed-off-by: Taekjin LEE <[email protected]>

refactor: add ssp.hpp to object association solver includes

e001f56

Signed-off-by: Taekjin LEE <[email protected]>

refactor: update include paths for object association node

e7baa9e

Signed-off-by: Taekjin LEE <[email protected]>

technolojin force-pushed the refactor/namespace_object_merger branch from 1f6c0b7 to e7baa9e Compare June 28, 2024 01:27

esteve approved these changes Jul 1, 2024

View reviewed changes

technolojin merged commit c2f9579 into autowarefoundation:main Jul 2, 2024
26 of 30 checks passed

esteve mentioned this pull request Jul 3, 2024

refactor(autoware_object_merger): move headers to src and rename package #7804

Merged

technolojin deleted the refactor/namespace_object_merger branch July 26, 2024 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(object_merger)!: fix namespace and directory structure #7642

refactor(object_merger)!: fix namespace and directory structure #7642

technolojin commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading

esteve left a comment

technolojin commented Jun 25, 2024 •

edited

Loading

technolojin commented Jun 25, 2024

yukkysaito left a comment

esteve left a comment

technolojin commented Jun 26, 2024 •

edited

Loading

technolojin commented Jul 1, 2024

esteve left a comment

refactor(object_merger)!: fix namespace and directory structure #7642

refactor(object_merger)!: fix namespace and directory structure #7642

Conversation

technolojin commented Jun 24, 2024 • edited Loading

Description

Tests performed

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jun 24, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 25, 2024 • edited Loading

esteve left a comment

Choose a reason for hiding this comment

technolojin commented Jun 25, 2024 • edited Loading

technolojin commented Jun 25, 2024

yukkysaito left a comment

Choose a reason for hiding this comment

esteve left a comment

Choose a reason for hiding this comment

technolojin commented Jun 26, 2024 • edited Loading

technolojin commented Jul 1, 2024

esteve left a comment

Choose a reason for hiding this comment

technolojin commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading

technolojin commented Jun 25, 2024 •

edited

Loading

technolojin commented Jun 26, 2024 •

edited

Loading